Skip to content

Conversation

rugeGerritsen
Copy link
Contributor

This PR unifies those boards which allows us to cleanup some tests.
See commit messages for additional details.

@rugeGerritsen rugeGerritsen requested a review from a team as a code owner September 29, 2025 09:10
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 29, 2025
@rugeGerritsen rugeGerritsen force-pushed the 53bsim_netcore_sysbuild branch from cab03ee to 464ad69 Compare September 29, 2025 09:13
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 29, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 43e798b3285a2ccf85d6b6e287f305dff0a498eb

more details

sdk-nrf:

PR head: 43e798b3285a2ccf85d6b6e287f305dff0a498eb
merge base: 5999ecf877bf2f926d7b83a03e79bff725a89d84
target head (main): 9710cb1e0290d18f7f0422c72c1caffd4b6725e4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
sysbuild
│  ├── Kconfig.netcore
│  │ netcore.cmake
tests
│  ├── bluetooth
│  │  ├── bsim
│  │  │  ├── nrf_auraconfig
│  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  ├── sysbuild.cmake
│  │  │  │  ├── tester
│  │  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  │  │ sysbuild.cmake

Outputs:

Toolchain

Version: a7529a11f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:a7529a11f4_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 7
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread-main - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_lrcs_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps-main - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 29, 2025

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.uart[[email protected]/nrf54h20/cpuapp]: RAM size increased by 23661[B] in comparison to the main[5999ecf] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54h20/cpuapp]: ROM size increased by 13752[B] in comparison to the main[5999ecf] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[[email protected]/nrf54h20/cpuapp]: RAM size increased by 23657[B] in comparison to the main[5999ecf] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[[email protected]/nrf54h20/cpuapp]: ROM size increased by 12044[B] in comparison to the main[5999ecf] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9102[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5858[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9492[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24742/7)

config SUPPORT_NETCORE
bool
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP)
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP || BOARD_NRF5340BSIM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aescolar should this be added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the POV of what the PR is doing I do not see any issue right away.
From the point of view of the actual kconfig option used, as this is a sysbuild file, I guess we are limited to not using the COMPATIBLE options, but that maybe BOARD_NRF5340BSIM_NRF5340_CPUAPP is a bit better.

config SUPPORT_NETCORE
bool
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP)
default y if (SOC_NRF5340_CPUAPP || SOC_NRF54H20_CPUAPP || BOARD_NRF5340BSIM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the POV of what the PR is doing I do not see any issue right away.
From the point of view of the actual kconfig option used, as this is a sysbuild file, I guess we are limited to not using the COMPATIBLE options, but that maybe BOARD_NRF5340BSIM_NRF5340_CPUAPP is a bit better.

@rugeGerritsen rugeGerritsen force-pushed the 53bsim_netcore_sysbuild branch 2 times, most recently from 2e60584 to 8c5bc5a Compare October 1, 2025 07:46
Copy link
Contributor

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


set_property(GLOBAL PROPERTY PM_DOMAINS ${PM_DOMAINS})

if (SB_CONFIG_BOARD_NRF5340BSIM_NRF5340_CPUAPP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (SB_CONFIG_BOARD_NRF5340BSIM_NRF5340_CPUAPP)
if(SB_CONFIG_BOARD_NRF5340BSIM_NRF5340_CPUAPP)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created zephyrproject-rtos/zephyr#96846 to address the underlying issue: Style checks not catching this

This commit sets defaults for the sysbuild configurations
SUPPORT_NETCORE and NETCORE_REMOTE_BOARD_TARGET_CPUCLUSTER
so that it behaves more similar to the actual 5340 soc.

This allows us to remove explicit adding of network core images.

Signed-off-by: Rubin Gerritsen <[email protected]>
Use NRF_DEFAULT_IPC_RADIO to enable building of the hci_ipc
radio sample for the network core instead of adding it manually.

Signed-off-by: Rubin Gerritsen <[email protected]>
@rugeGerritsen rugeGerritsen force-pushed the 53bsim_netcore_sysbuild branch from 8c5bc5a to 43e798b Compare October 1, 2025 07:58
@rugeGerritsen rugeGerritsen requested a review from nordicjm October 1, 2025 07:58
@rugeGerritsen rugeGerritsen merged commit ed14049 into nrfconnect:main Oct 1, 2025
13 checks passed
@rugeGerritsen rugeGerritsen deleted the 53bsim_netcore_sysbuild branch October 1, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants